Skip to content

fix(core): Updated aria labels for ix-icon-buttons #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GayatriK2002 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(core): Updated aria labels for ix-icon-buttons #2361

GayatriK2002 wants to merge 4 commits into from

Conversation

@GayatriK2002
Copy link
Collaborator

@GayatriK2002 GayatriK2002 commented Jan 27, 2026

💡 What is the current behavior?

  • Icon-only buttons announce as "unknown" to screen readers because aria-label attributes are removed after first render and lost on component re-renders.

GitHub Issue Number: #
Jira Issue Number: 3846, 3845

🆕 What is the new behavior?

  • Added persistent ariaLabelButton prop to ix-icon-button with context-aware labels (e.g., "Collapse pane"/"Expand pane", "Open calendar", "Clear selection") that survive re-renders. Fallback to icon name parsing if no label provided. Users can override via props or host attributes.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📕 Add or update a Storybook story
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 976069a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@GayatriK2002 GayatriK2002 changed the title updated aria labels for ix-icon-buttons fix(core): Updated aria labels for ix-icon-buttons Jan 27, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 28, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GayatriK2002 GayatriK2002 marked this pull request as ready for review January 28, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GayatriK2002